Matthias Clasen [Sat, 22 Jun 2019 02:35:52 +0000 (02:35 +0000)]
widget actions: Add an explicit state type
Make the state type part of the API for installing
stateful widget actions. That lets us introspect it.
Update all callers.
Matthias Clasen [Sat, 22 Jun 2019 00:04:37 +0000 (00:04 +0000)]
application: Stop extracting accels from menus
This functionality has been superseded by
gtk_application_set_accels_for_action in GTK3,
and we don't want to carry it forward in GTK4.
Goran Vidović [Fri, 21 Jun 2019 23:38:11 +0000 (23:38 +0000)]
Update Croatian translation
Goran Vidović [Fri, 21 Jun 2019 22:40:38 +0000 (22:40 +0000)]
Update Croatian translation
Goran Vidović [Fri, 21 Jun 2019 22:06:32 +0000 (22:06 +0000)]
Update Croatian translation
Goran Vidović [Fri, 21 Jun 2019 11:17:40 +0000 (11:17 +0000)]
Update Croatian translation
Goran Vidović [Fri, 21 Jun 2019 10:49:10 +0000 (10:49 +0000)]
Update Croatian translation
Daniel Mustieles [Fri, 21 Jun 2019 08:04:41 +0000 (10:04 +0200)]
Updated Spanish translation
Matthias Clasen [Fri, 21 Jun 2019 03:57:26 +0000 (03:57 +0000)]
Add a test for GtkText actions
Check that the class actions are there and work.
Matthias Clasen [Fri, 21 Jun 2019 03:41:25 +0000 (03:41 +0000)]
Add a test for gtk_widget_insert_action_group
This tests that action group inheritance
behaves as expected.
Matthias Clasen [Fri, 21 Jun 2019 02:55:27 +0000 (02:55 +0000)]
window: Cosmetics
Matthias Clasen [Wed, 19 Jun 2019 04:26:15 +0000 (04:26 +0000)]
inspector: Fix actions visibility
We need to always hide the page when setting
an object, otherwise the initial visibility
sticks.
Matthias Clasen [Wed, 19 Jun 2019 11:11:06 +0000 (11:11 +0000)]
inspector: Use event controller names
Use these in the same place we use widget names.
Matthias Clasen [Wed, 19 Jun 2019 11:09:38 +0000 (11:09 +0000)]
event controller: Add a name property
This helps identifying controllers in the inspector.
Matthias Clasen [Fri, 21 Jun 2019 02:47:35 +0000 (22:47 -0400)]
Build fix
Matthias Clasen [Fri, 21 Jun 2019 02:26:04 +0000 (02:26 +0000)]
Fix initial mnemonic visibility
We were showing mnemonics initially, which is not desired.
Matthias Clasen [Fri, 21 Jun 2019 02:22:26 +0000 (02:22 +0000)]
main: Move visible mnemonics handling
No need to special-case this anymore; we can use
a regular event controller in GtkWindow for this.
Matthias Clasen [Fri, 21 Jun 2019 01:57:51 +0000 (01:57 +0000)]
main: Move visible focus handling
No need to special-case this anymore; we can use
a regular event controller in GtkWindow for this.
Daniel Boles [Thu, 13 Jun 2019 17:22:33 +0000 (18:22 +0100)]
Overlay: Document overlay children aren't measured
Some users expect that the Overlay will automatically request enough
size for its overlay children as well as its main child. It doesn't,
because it's just a GtkBin. Add a short paragraph pointing that out.
Close https://gitlab.gnome.org/GNOME/gtk/issues/1939
Efstathios Iosifidis [Thu, 20 Jun 2019 20:26:15 +0000 (20:26 +0000)]
Update Greek translation
Efstathios Iosifidis [Thu, 20 Jun 2019 20:10:21 +0000 (20:10 +0000)]
Update Greek translation
Daniel Boles [Thu, 20 Jun 2019 19:51:37 +0000 (20:51 +0100)]
FileChooserButton: Document the CSS nodes & class
The only glancing mention of this we had was that GtkButton mentioned it
in passing when discussing how `button` could get contextual classes,
and even that's not relevant in master anymore... so drop it from there.
Daniel Mustieles [Wed, 19 Jun 2019 08:10:08 +0000 (10:10 +0200)]
Updated Spanish translation
Daniel Mustieles [Wed, 19 Jun 2019 08:09:03 +0000 (10:09 +0200)]
Updated Spanish translation
Daniel Boles [Tue, 18 Jun 2019 20:43:07 +0000 (21:43 +0100)]
ListBox: Document buildable child type placeholder
andyholmes on IRC asked about this and it wasn't documented, so fix that
Daniel Boles [Tue, 18 Jun 2019 20:42:40 +0000 (21:42 +0100)]
Window: Hyperlink to GtkBuildable from its section
Benjamin Otte [Sat, 4 Aug 2018 21:10:05 +0000 (23:10 +0200)]
gsk: Fix annotations for ref()/unref()
Benjamin Otte [Tue, 31 Jul 2018 05:49:36 +0000 (07:49 +0200)]
bindings: Make gtk_binding_entry_add_signall() private
This function needs a replacement and that will appear after
refactorings.
Benjamin Otte [Tue, 31 Jul 2018 05:36:09 +0000 (07:36 +0200)]
bindings: Hide structs
Benjamin Otte [Tue, 31 Jul 2018 05:24:58 +0000 (07:24 +0200)]
bindings: Remove unused member variables
Benjamin Otte [Wed, 1 Aug 2018 19:13:06 +0000 (21:13 +0200)]
x11: Actually call the finished func when finishing
Copy/paste madness was calling the status func...
Benjamin Otte [Thu, 23 Aug 2018 04:39:33 +0000 (06:39 +0200)]
testgtk: Remove unused code
This code has been doing nothing since 2010 when the optionmenu was
removed in
274395063a051717ad9eb5ceab8213724552ad72.
Benjamin Otte [Sun, 5 Aug 2018 01:17:31 +0000 (03:17 +0200)]
contentformats: Fix doc typo
Matthias Clasen [Tue, 18 Jun 2019 19:10:45 +0000 (19:10 +0000)]
Merge branch 'widget-class-actions-2' into 'master'
Widget class action
See merge request GNOME/gtk!948
Matthias Clasen [Sat, 15 Jun 2019 04:15:37 +0000 (00:15 -0400)]
Docs: expand actions chapter
Mention widget class actions and non-global actions
in various places.
Matthias Clasen [Sat, 15 Jun 2019 03:56:45 +0000 (03:56 +0000)]
color chooser widget: Use the new action machinery
Port GtkColorChooserWidget to use widget class actions.
Note that this also changes the names of
the GtkColorChooserWidget actions away from a generic
"context" prefix.
Matthias Clasen [Sat, 15 Jun 2019 02:25:46 +0000 (02:25 +0000)]
link button: Use the new action machinery
Port GtkLinkButton to use widget class actions.
Note that this also changes the names of
the GtkLinkButton actions away from a generic
"context" prefix.
Matthias Clasen [Sat, 15 Jun 2019 01:43:20 +0000 (21:43 -0400)]
window: Use the new action machinery
Change the default.activate action to use the
new action machinery.
Matthias Clasen [Sat, 15 Jun 2019 01:27:27 +0000 (01:27 +0000)]
textview: Use the new action machinery
Port GtkTextView to use widget class actions.
Note that this also changes the names of
the GtkTextView actions away from a generic
"context" prefix.
Matthias Clasen [Sat, 15 Jun 2019 00:05:51 +0000 (20:05 -0400)]
label: Use the new action machinery
Port GtkLabel to use widget class actions.
Note that this also changes the names of
the GtkLabel actions away from a generic
"context" prefix.
Matthias Clasen [Sat, 15 Jun 2019 19:30:10 +0000 (19:30 +0000)]
password entry: Adapt to action name change
Also fix updating the icon when changing visibility
via the context menu.
Matthias Clasen [Fri, 14 Jun 2019 16:43:42 +0000 (16:43 +0000)]
text: Use the new action machinery
Port GtkText to use widget class actions.
Note that this also changes the names of
the GtkText actions away from a generic
"context" prefix.
Matthias Clasen [Fri, 14 Jun 2019 12:12:10 +0000 (12:12 +0000)]
Allow registering actions per-class
Add a facility to register and install actions
at class init time. The intended use for these
actions is for
a) context and other model-based menus
b) key bindings
Most of these actions are going to be stateless,
so add separate apis for the simple and stateful
cases.
We avoid creating an action group for these by
teaching the action muxer about these actions.
The action muxer also maintains the enabled
state for these actions.
Matthias Clasen [Sat, 15 Jun 2019 23:08:39 +0000 (23:08 +0000)]
Give the action muxer a widget
This will be used in the future to obtain
widget class actions.
Jakub Steiner [Mon, 17 Jun 2019 17:52:32 +0000 (19:52 +0200)]
Adwaita: tone down infobars
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1957
Matthias Clasen [Mon, 17 Jun 2019 17:03:21 +0000 (17:03 +0000)]
Merge branch 'egl-config-8888' into 'master'
wayland: Explicitly require RGBA8888
See merge request GNOME/gtk!944
Matthias Clasen [Mon, 17 Jun 2019 16:41:01 +0000 (12:41 -0400)]
wayland: Explicitly require RGBA8888
Its the format we expect to have. If we want to
support 10-bit visuals at some point, that should
be an explicit decision.
Matthias Clasen [Mon, 17 Jun 2019 03:26:35 +0000 (03:26 +0000)]
Merge branch 'matthiasc-for-master' into 'master'
Matthiasc for master
See merge request GNOME/gtk!943
Matthias Clasen [Mon, 17 Jun 2019 02:46:48 +0000 (22:46 -0400)]
popover: Drop unused api
The inspector is no longer using this
list model, so drop the api.
Matthias Clasen [Mon, 17 Jun 2019 02:45:17 +0000 (22:45 -0400)]
inspector: Don't duplicate popovers
Popovers are now regular children in the widget
tree, no need to duplicate them as toplevels
in the object tree.
Matthias Clasen [Mon, 17 Jun 2019 02:10:33 +0000 (02:10 +0000)]
inspector: Add a refresh button for actions
Action state updates may not always be precise.
Matthias Clasen [Mon, 17 Jun 2019 01:21:17 +0000 (21:21 -0400)]
inspector: Fix centering of subtitles
Piotr Drąg [Sun, 16 Jun 2019 11:34:36 +0000 (13:34 +0200)]
Update Polish translation
Matthias Clasen [Sun, 16 Jun 2019 01:59:58 +0000 (01:59 +0000)]
Merge branch 'matthiasc-for-master' into 'master'
Matthiasc for master
See merge request GNOME/gtk!942
Matthias Clasen [Sat, 15 Jun 2019 22:36:46 +0000 (22:36 +0000)]
Drop gtk_widget_get_action_group
Ths api exposes too much of the internal
action muxer setup; we want to add actions
to the muxer without an action group.
Matthias Clasen [Sat, 15 Jun 2019 22:25:05 +0000 (22:25 +0000)]
places sidebar: Stop using gtk_widget_get_action_group
We create this action group ourselves,
we can keep track of it.
Matthias Clasen [Sat, 15 Jun 2019 22:24:26 +0000 (22:24 +0000)]
file chooser: Stop using gtk_widget_get_action_group
We create this action group ourselves,
we can keep track of it.
Matthias Clasen [Fri, 14 Jun 2019 16:43:58 +0000 (16:43 +0000)]
entry: Remove hacky code
We can leave it up to apps to not set less-than-useful
combinations, such as show-emoji-icon, but a no-emoji
input hint.
Matthias Clasen [Sun, 16 Jun 2019 00:17:45 +0000 (00:17 +0000)]
widget: Remove gtk_widget_list_action_prefixes
This function was added just for the inspector,
and is not used there anymore. Drop it.
Matthias Clasen [Sat, 15 Jun 2019 22:10:33 +0000 (22:10 +0000)]
widget: Cosmetics
Matthias Clasen [Sat, 15 Jun 2019 22:05:54 +0000 (22:05 +0000)]
inspector: Fix actionable handling
Matthias Clasen [Sat, 15 Jun 2019 21:54:45 +0000 (21:54 +0000)]
inspector: Redo the action page
Instead of iterating action groups manually,
just show what the action muxer provides. This
gives an accurate view of what actions are
available in a widgets context, and saves us
the trouble of juggling prefixes manually.
Matthias Clasen [Sat, 15 Jun 2019 22:04:19 +0000 (22:04 +0000)]
action muxer: cosmetics
Matthias Clasen [Fri, 14 Jun 2019 17:41:45 +0000 (13:41 -0400)]
action muxer: Add some convenience api
Instead of duplicating this code in multiple places,
add an api to look up an action group for a prefixed
name, and return the unprefixed name at the same time.
Matthias Clasen [Sun, 16 Jun 2019 01:38:12 +0000 (01:38 +0000)]
menu tracker item: Improve logging
Pass the action name along, so we can put
it in log messages.
Matthias Clasen [Sat, 15 Jun 2019 04:51:11 +0000 (00:51 -0400)]
Remove an accidental addition
Daniel Boles [Fri, 14 Jun 2019 17:05:06 +0000 (18:05 +0100)]
testsuite/a11y/about: Fix exp. output per
31066a69
cherry-pick of commit
e56a9e6ce5acd05677ece04c85ef219555a5f8e5
Close #1949
Matthias Clasen [Thu, 13 Jun 2019 22:28:37 +0000 (22:28 +0000)]
Merge branch 'wip/chergert/profiler-event-marks-4' into 'master'
profiler: add profiler marks for surface event delivery
See merge request GNOME/gtk!934
Christian Hergert [Thu, 13 Jun 2019 19:37:16 +0000 (12:37 -0700)]
profiler: add profiler marks for surface event delivery
This gives us marks to track the duration of processing certain types of
GdkEvent. It also provides some basic struct information in cases where
having that information would likely be useful for debugging.
Matthias Clasen [Thu, 13 Jun 2019 21:11:56 +0000 (21:11 +0000)]
Merge branch 'gtkprintunixdialog-ui' into 'master'
Slightly ease page range entry in PrintUnixDialog
Closes #591
See merge request GNOME/gtk!922
Guillaume Maudoux [Thu, 13 Jun 2019 21:11:56 +0000 (21:11 +0000)]
PrintUnixDialog: Slightly ease page range entry
Page ranges entry can now be focused directly, and will automatically
select the page ranges button when doing so.
This avoids the sometimes counter-intuitive previous behavior where the
entry was automatically focused when toggling the radio button, but the
user may still find themselves clicking uselessly in the text entry
because they scheduled it in their mental model.
Balázs Meskó [Thu, 13 Jun 2019 20:13:42 +0000 (20:13 +0000)]
Update Hungarian translation
Matthias Clasen [Thu, 13 Jun 2019 19:58:07 +0000 (15:58 -0400)]
print operation: Reinstate the priv pointer
The attempt to drop it in
6a669265ac6854af0ec
was incomplete, and non-working.
Matthias Clasen [Thu, 13 Jun 2019 19:31:48 +0000 (19:31 +0000)]
headerbar: Fix fallback appmenu
We were using menubuttons here in a way that
does not work anymore. Make it work again.
Piotr Drąg [Thu, 13 Jun 2019 16:54:42 +0000 (18:54 +0200)]
Update POTFILES.in
Matthias Clasen [Thu, 13 Jun 2019 16:45:07 +0000 (16:45 +0000)]
Merge branch 'message-dialog-title' into 'master'
Message dialog title
See merge request GNOME/gtk!894
Matthias Clasen [Fri, 31 May 2019 12:10:02 +0000 (12:10 +0000)]
message dialog: Stop hardcoding title styles
Instead, use a new title style class to let
themes influence title formatting. Note that
the theme style will be overridden if the
application uses markup for presentation,
such as <b> or <i>.
Matthias Clasen [Thu, 13 Jun 2019 12:17:54 +0000 (12:17 +0000)]
Merge branch 'wip/matthiasc/context-menu' into 'master'
context menu api
See merge request GNOME/gtk!539
Matthias Clasen [Wed, 12 Jun 2019 03:02:15 +0000 (03:02 +0000)]
color chooser: Use a popover menu
Make the color chooser use a popover menu
and actions.
Matthias Clasen [Wed, 12 Jun 2019 01:34:19 +0000 (01:34 +0000)]
link button: Use new context menu api
Matthias Clasen [Thu, 11 Apr 2019 18:48:06 +0000 (14:48 -0400)]
treeview: Stop disabling the context menu
Matthias Clasen [Tue, 5 Feb 2019 08:52:38 +0000 (03:52 -0500)]
places sidebar: remove populate-popup
Matthias Clasen [Tue, 5 Feb 2019 08:52:03 +0000 (03:52 -0500)]
cell renderer: remove populate-popup
Matthias Clasen [Tue, 29 Jan 2019 00:14:36 +0000 (19:14 -0500)]
widget-factory: Redo the context menu example
Redo the context menu on the page1 text view in
terms of actions.
Matthias Clasen [Sun, 27 Jan 2019 05:57:42 +0000 (00:57 -0500)]
gtk-demo: Rewrite the search entry demo
Port this from ::populate-popup to the new context
menu api. At the same time, fix some parts of the demo
that were broken since it was changed to use GtkStearchEntry.
Matthias Clasen [Tue, 29 Jan 2019 00:56:08 +0000 (19:56 -0500)]
textview: Support toggle actions
When creating a touch selection bubble, create toggle
buttons for toggle actions.
Matthias Clasen [Mon, 28 Jan 2019 21:47:53 +0000 (16:47 -0500)]
textview: Redo context menus
Drop the ::populate-popup signal and implement
the new context menu api.
Matthias Clasen [Sun, 27 Jan 2019 21:43:54 +0000 (16:43 -0500)]
label: Redo context menus
Drop the ::populate-popup signal and implement
the new context menu api. Things are a bit more
complicated here, since we have different menus
on links and selectable text.
Matthias Clasen [Thu, 11 Apr 2019 18:46:55 +0000 (14:46 -0400)]
password entry: Adapt to new context menu api
Matthias Clasen [Thu, 11 Apr 2019 18:47:20 +0000 (14:47 -0400)]
text: Add a context action for visibility
This will be used by GtkPasswordEntry for amending
the context menu.
Matthias Clasen [Mon, 8 Apr 2019 04:27:59 +0000 (04:27 +0000)]
text, entry: Implement context menu api
Drop the ::populate-popup signal and implement
the new context menu api.
Matthias Clasen [Thu, 13 Jun 2019 00:13:21 +0000 (00:13 +0000)]
popover menu: Unify hover and focus
Menus traditionally don't have separate
hover and focus locations. Make the same
change here that we already did for
popover menubars: Track the active item
and set its selected state. Both keynav
and mouse change the active item.
Matthias Clasen [Thu, 13 Jun 2019 00:12:33 +0000 (00:12 +0000)]
popover menubar: Use a pseudo state
Use :selected instead of .active to
mark the active item.
Matthias Clasen [Thu, 13 Jun 2019 00:11:32 +0000 (00:11 +0000)]
popover: Improve the move-focus fix
Avoid breaking menubar keynav (we still
need the focus change to be propagated
down from the root).
Matthias Clasen [Wed, 12 Jun 2019 19:54:26 +0000 (19:54 +0000)]
popover menu bar: Don't leave active item behind
When the mouse leaves the bar, turn the lights off.
Matthias Clasen [Wed, 12 Jun 2019 19:07:29 +0000 (19:07 +0000)]
wayland: Fix the popover race workaround
The Wayland backend has a hack to work around
a race with popover mapping: If the surface size
changes before the initial configure, we hide and
show the surface. Unfortunately, the code was doing
this in a way that is externally observable (by
listening for surface state changes), and popovers
were observing it and hiding themselves in response.
Avoid this by not going through the GDK frontend
code for this.
Matthias Clasen [Wed, 12 Jun 2019 16:55:43 +0000 (16:55 +0000)]
popover menu: Add our own activate key bindings
This solves issues with parent widgets, like combobox
or entry, installing their own bindings for these
keys, overriding the activation behavior that
is implemented in gtkwindow.
Matthias Clasen [Wed, 12 Jun 2019 16:54:57 +0000 (16:54 +0000)]
popover: Bring back the activate-default signal
As long as key bindings only work via action
signals, we need a signal here in order to
override the Enter/Space bindings for popover
menus.
Matthias Clasen [Wed, 12 Jun 2019 16:35:36 +0000 (16:35 +0000)]
popover menu: Add our own focus key bindings
This solves issues with parent widgets, like textview
or scrolled window or combobox installing their own
bindings for these keys, overriding the focus behavior
that is implemented in gtkwindow.
Matthias Clasen [Wed, 12 Jun 2019 00:56:40 +0000 (00:56 +0000)]
color editor: Don't leak adjustments